Contributing to Mozilla. Part 2

In one of my previous stories, I have shared my experiences with starting contributions to one of Mozilla’s numerous projects. After starting the initial work on one of the issues, I was in a good shape to rock it. Today I would like to share more on how it went so far!

After creating my initial PR, the work on the issue definitely was not completed just yet! Shortly after the PR was open, it has received a couple or reviews from two members of the project. Sadly, I have made some mistake with the package.jsonfile, introducing one of the packages twice:

Image for post
Image for post
Luca’s comment regarding package.json

As a result, I was reminded once more how important it is not to use git add . when staging your changes, and that under any circumstances should you check the change list before pushing your update to a remote.

However, apart from this little bug, there where some other serious things to consider.

Image for post
Image for post
Luca’s comment regarding extention & validation

In order to successfully implement the -filename option, it is needed to complete at least some minimal checks. For instance, ensuring that the filename entered does not contain any relative or absolute paths. That way, we would be able to make sure that the package created would appear in the right folder. Besides that, the extension of the package should actually be customizable as well.

Image for post
Image for post
Luca’s comment regarding aliases

Apart from that, we would also need to eliminate any duplicates within command shortcuts.

Image for post
Image for post

Even though 'f'alias has only been used in other module, we would rather want to minimize the risk of any confusions/mistakes and either create some other unique alias, or come up with none at all. At this point, it seems to me that the last option is more favourable, because using any other single character alias apart from 'f'just doesn’t seem logical or intuitive.

Last, but not least, there is also another request to complete.

Image for post
Image for post
Rob’s comment regarding variables

What needs to be done is to implement the variables replacements support within the filename provided. It seems to be not that of a straightforward task, which would involve some regular expressions.

Luckily, I have received some follow-up comments providing more details on how I should approach the task.

Image for post
Image for post
Luca’s follow up on the variable feature request

Overall, the initial result was not that bad and I’m satisfying with the progress that has been achieved so far. I have already put in some work to fix the issues described above and I hope that I can manage to utilize on the help provided by the project members to push this PR closer to the merge. I feel really pumped to work on this issue together with people from Mozilla!

Enthusiastic Junior Software Developer striving for discoveries & curious about technology

Get the Medium app

A button that says 'Download on the App Store', and if clicked it will lead you to the iOS App store
A button that says 'Get it on, Google Play', and if clicked it will lead you to the Google Play store